Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some 3D additions: Matrix3+Quaternion compatibility, some missing methods in Vector3 and Matrix4. Support EulerAngles in arbitrary rotation orders. #1725

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Some 3D additions: Matrix3+Quaternion compatibility, some missing methods in Vector3 and Matrix4. Support EulerAngles in arbitrary rotation orders. #1725

merged 8 commits into from
Jun 26, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Jun 25, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 68.33% and project coverage change: +0.11 🎉

Comparison is base (01def82) 50.95% compared to head (008764f) 51.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   50.95%   51.06%   +0.11%     
==========================================
  Files        1728     1732       +4     
  Lines      100996   101340     +344     
  Branches    14341    14374      +33     
==========================================
+ Hits        51458    51746     +288     
- Misses      45587    45657      +70     
+ Partials     3951     3937      -14
Flag Coverage Δ
unittests 51.06% <68.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/korlibs/image/vector/Context2dArrowExt.kt 0.00% <0.00%> (ø)
...src/commonMain/kotlin/korlibs/math/geom/Matrix4.kt 20.62% <0.00%> (-0.20%) ⬇️
.../korlibs/math/geom/vector/VectorBuilderArrowExt.kt 0.00% <0.00%> (ø)
...c/commonTest/kotlin/korlibs/math/geom/AssertExt.kt 38.09% <0.00%> (-2.94%) ⬇️
...src/commonMain/kotlin/korlibs/math/geom/Vector2.kt 50.73% <41.17%> (-0.31%) ⬇️
...commonMain/kotlin/korlibs/math/geom/Orientation.kt 68.18% <50.00%> (+7.07%) ⬆️
.../commonMain/kotlin/korlibs/math/geom/Quaternion.kt 51.23% <65.00%> (+3.71%) ⬆️
...a/src/commonMain/kotlin/korlibs/math/geom/Angle.kt 74.82% <66.66%> (-0.56%) ⬇️
...src/commonMain/kotlin/korlibs/math/geom/Matrix3.kt 71.11% <71.11%> (ø)
...src/commonMain/kotlin/korlibs/math/geom/Vector3.kt 45.20% <100.00%> (+0.76%) ⬆️
... and 4 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz changed the title Some 3D additions: Matrix3+Quaternion compatibility, some missing methods in Vector3 and Matrix4 Some 3D additions: Matrix3+Quaternion compatibility, some missing methods in Vector3 and Matrix4. Support EulerAngles in arbitrary rotation orders. Jun 26, 2023
@soywiz soywiz merged commit 0dd7c48 into main Jun 26, 2023
10 checks passed
@soywiz soywiz deleted the feature/add.Matrix3 branch October 4, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soywiz @codecov-commenter